Patch: fix ISTA/FISTA with complex numbers#692
Merged
Conversation
mrava87
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of fixes for ISTA/FISTA to allow them to run with complex valued model vectors and operators, namely:
decay, making sure it is always a real valued array (also for complex valued operators). This suppresses a warning in_hardthreshold._halfthresholdis now performed separately for real and imag part of complex valued arraysAdditionally, some of the tests in
test_sparsityare modified to also test scenarios with complex valued model vectors and operators.